[webkit-reviews] review denied: [Bug 102534] [chromium] Add flag to enable/disable touch adjustment at runtime. : [Attachment 175274] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Kevin Ellis
<kevers at chromium.org>'s request for review:
Bug 102534: [chromium] Add flag to enable/disable touch adjustment at runtime.
https://bugs.webkit.org/show_bug.cgi?id=102534

Attachment 175274: Patch
https://bugs.webkit.org/attachment.cgi?id=175274&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175274&action=review


Looks good. One minor issue, one request and one question.

would like to see another round before it lands, then the r-.

> Source/WebCore/ChangeLog:9
> +	   [chromium] Add flag to enable/disable touch adjustment at runtime.
> +	   https://bugs.webkit.org/show_bug.cgi?id=102534
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add setting for enabling or disabling touch adjustment.
> +

You should mention here why the compile time only flag is not enough. Things
like when compile-time would be enabled, but the run-time setting disable, etc.


> Source/WebCore/page/EventHandler.cpp:2701
> +bool EventHandler::shouldApplyTouchAdjustment(const PlatformGestureEvent&
event)

const?

> Source/WebCore/page/Settings.in:143
> +touchAdjustmentEnabled initial=true

default true? How does it work when the compile flag is disabled? Do we care?
Found it a bit odd ...