[webkit-reviews] review canceled: [Bug 102647] [CMake] Add an option to build AllInOne files : [Attachment 174895] 1st try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 13:44:51 PST 2012


Laszlo Gombos <laszlo.gombos at webkit.org> has canceled Laszlo Gombos
<laszlo.gombos at webkit.org>'s request for review:
Bug 102647: [CMake] Add an option to build AllInOne files
https://bugs.webkit.org/show_bug.cgi?id=102647

Attachment 174895: 1st try
https://bugs.webkit.org/attachment.cgi?id=174895&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
> After stripping the binaries the gain is even bigger on Linux release binary
for the EFL port - 876kB - (2.58% gain).

Taking this idea one step further further - after stripping _and_ introducing
binary optimization (see bug 102827) the gain on binary size saving seems to
increase to 923kb. The important observation here that the 2 optimization
technique (bug 102647 and bug 102827) seems to be independent.

As a side note AllInOne build option also seems to decrease the build time (for
me about 10%) for a full (non-incremental) build.

I will update the patch to reflect on comments.


More information about the webkit-reviews mailing list