[webkit-reviews] review denied: [Bug 97696] [Chromium][Win] Remove ensureFontLoaded from PlatformSupport : [Attachment 175004] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 97696: [Chromium][Win] Remove ensureFontLoaded from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97696

Attachment 175004: Patch
https://bugs.webkit.org/attachment.cgi?id=175004&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175004&action=review


>> Source/WebCore/platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:-64
>> -	    if (PlatformSupport::ensureFontLoaded(m_platformData.hfont())) {
> 
> I wonder if we should provide this helper function in WebCore somewhere
rather than inlining it everywhere.

IMHO, we should add this helper function.  Otherwise, we're making all these
call sites much more verbose.