[webkit-reviews] review denied: [Bug 101346] No condition present to check if Compressed Texture S3TC extension support exists : [Attachment 175248] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied akaushik at rim.com's request for
review:
Bug 101346: No condition present to check if Compressed Texture S3TC extension
support exists
https://bugs.webkit.org/show_bug.cgi?id=101346

Attachment 175248: Patch
https://bugs.webkit.org/attachment.cgi?id=175248&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175248&action=review


Looks fair overall but needs a little more work.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2382
> +	   &&
m_context->getExtensions()->supports("GL_EXT_texture_compression_s3tc")) {

Use WebGLCompressedTextureS3TC::supported(WebGLRenderingContext*) instead to
keep the checks here and WebGLRenderingContext::getSupportedExtensions
symmetric.