[webkit-reviews] review denied: [Bug 102677] Meta tag should be scanned until meet </head> : [Attachment 175155] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 102677: Meta tag should be scanned until meet </head>
https://bugs.webkit.org/show_bug.cgi?id=102677

Attachment 175155: patch
https://bugs.webkit.org/attachment.cgi?id=175155&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175155&action=review


I don't object to tweaking the charset scanner in general, however this patch
is confusing, and still doesn't seem correct.

It might be that fixing this site is impossible without breaking some other
cases we fixed in the past.

> Source/WebCore/ChangeLog:3
> +	   Meta tag should be scanned until meet </head>

The description of the change is confusing. Did you mean to say "at least until
</head>"? But that would break incremental rendering, as discussed before.

Bug 3590 has an example of <meta charset> after </head>, so stopping at </head>
would be wrong.

> Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp:163
> +    // We continue scanning until meet </head> tag because this more closely

> +    // matches with other browsers, e.g. FF, Opera and IE, in its behavior;
> +    // see <https://bugs.webkit.org/show_bug.cgi?id=102677>.

This is not accurate, Firefox does not have any such logic any more. I'll
attach a test case momentarily.