[webkit-reviews] review denied: [Bug 102452] Plumbing showPaintRects out of InspectorPageAgent to use a different drawing implementation if available. : [Attachment 174747] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied egraether at chromium.org's
request for review:
Bug 102452: Plumbing showPaintRects out of InspectorPageAgent to use a
different drawing implementation if available.
https://bugs.webkit.org/show_bug.cgi?id=102452

Attachment 174747: Patch
https://bugs.webkit.org/attachment.cgi?id=174747&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174747&action=review


Looks good overall, couple of naming nits and it can land.

> Source/WebCore/inspector/InspectorClient.h:75
> +    virtual bool canShowPaintRects() { return false; }

So its semantics is a bit different: it tells you whether embedder should
handle paint rects. I'd name it overridesShowPaintRects().

> Source/WebKit/chromium/public/WebView.h:474
> +    virtual bool canShowHUDLayer() = 0;

Should this be called isAcceleratedCompositingActive ? Just to make things more
clear.