[webkit-reviews] review granted: [Bug 102817] Reset the slider thumb location before every layout of the slider container : [Attachment 175231] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 102817: Reset the slider thumb location before every layout of the slider
container
https://bugs.webkit.org/show_bug.cgi?id=102817

Attachment 175231: Patch
https://bugs.webkit.org/attachment.cgi?id=175231&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175231&action=review


> Source/WebCore/html/shadow/SliderThumbElement.cpp:185
> +    if (input->sliderThumbElement() &&
input->sliderThumbElement()->renderer()) {
> +	   thumb = toRenderBox(input->sliderThumbElement()->renderer());
> +	   // Reset the thumb location before layout.
> +	   thumb->setLocation(LayoutPoint());
> +    }

When we call thumbLocation.setX, can we set the position to offset rather than
adding in the old position?