[webkit-reviews] review granted: [Bug 96637] Remove V8DOMWindowShell::getEntered : [Attachment 175227] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dan Carney <dcarney at google.com>'s
request for review:
Bug 96637: Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Attachment 175227: Patch
https://bugs.webkit.org/attachment.cgi?id=175227&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175227&action=review


Very nice.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:58
> +

By the way, is there a reason we have:

class DOMWrapperWorld : public WTF::RefCountedBase

The normal pattern is

class DOMWrapperWorld : public RefCounted<DOMWrapperWorld>

Sorry if I asked you that before and forgot.