[webkit-reviews] review denied: [Bug 101605] Web Inspector: Add UA Strings for iOS6 as well as IE Mobile 9 & 10 : [Attachment 173052] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 07:53:08 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 101605: Web Inspector: Add UA Strings for iOS6 as well as IE Mobile 9 & 10
https://bugs.webkit.org/show_bug.cgi?id=101605

Attachment 173052: Patch
https://bugs.webkit.org/attachment.cgi?id=173052&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173052&action=review


> Source/WebCore/inspector/front-end/SettingsScreen.js:428
> +	       ["Internet Explorer Mobile 10 \u2014 Lumina 920", "Mozilla/5.0
(compatible; MSIE 10.0; Windows Phone 8.0; Trident/6.0; IEMobile/10.0; ARM;
Touch; NOKIA; Lumia 920)", "768x1280x1"],

It started as sorted by potential popularity, so sounds like Lumina should not
be this high. But now that the list is so big, we should probably switch to
alphabetical sorting.


More information about the webkit-reviews mailing list