[webkit-reviews] review granted: [Bug 79441] IPP optimization for functions vsma, vsmul, vadd, vmul and vmaxmgv : [Attachment 131495] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 22:45:05 PST 2012


Brent Fulgham <bfulgham at webkit.org> has granted Gao Chun <chun.gao at intel.com>'s
request for review:
Bug 79441: IPP optimization for functions vsma, vsmul, vadd, vmul and vmaxmgv
https://bugs.webkit.org/show_bug.cgi?id=79441

Attachment 131495: Patch
https://bugs.webkit.org/attachment.cgi?id=131495&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131495&action=review


Seems like all requested changes have been made, and look reasonable.  I found
a tiny typo, but that can be fixed when this is landed.

> Source/WebCore/platform/audio/VectorMath.cpp:248
> +    if ((sourceStride1 ==1) && (sourceStride2 == 1) && (destStride == 1)) {

Nit: We need a space between the equals and the 1 here. ("==1" should be "==
1").


More information about the webkit-reviews mailing list