[webkit-reviews] review granted: [Bug 102578] Apply DeviceController as parent class of DeviceMotionController. : [Attachment 174802] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 18:47:18 PST 2012


Hajime Morrita <morrita at google.com> has granted Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 102578: Apply DeviceController as parent class of DeviceMotionController.
https://bugs.webkit.org/show_bug.cgi?id=102578

Attachment 174802: Patch
https://bugs.webkit.org/attachment.cgi?id=174802&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review


Looks good. Please fix some nit-picky bits on ChangeLog before landing.

> Source/WebCore/ChangeLog:8
> +	   DeviceController need to be applied as parent class of
DeviceMotionController

s/need/needs/


More information about the webkit-reviews mailing list