[webkit-reviews] review granted: [Bug 102661] Move in animation should be disabled until the calendar picker is loaded. : [Attachment 174930] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 18:31:06 PST 2012


Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 102661: Move in animation should be disabled until the calendar picker is
loaded.
https://bugs.webkit.org/show_bug.cgi?id=102661

Attachment 174930: Patch
https://bugs.webkit.org/attachment.cgi?id=174930&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174930&action=review


> Source/WebCore/Resources/pagepopups/calendarPicker.js:1317
> +    if (this.picker.isPreparing)
> +	   return;

I feel Introducing a new flag is inelegant though it's ok if there are no
better ways.


More information about the webkit-reviews mailing list