[webkit-reviews] review denied: [Bug 102689] [WinCairo] Crash when requesting favicon. : [Attachment 174980] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
review:
Bug 102689: [WinCairo] Crash when requesting favicon.
https://bugs.webkit.org/show_bug.cgi?id=102689

Attachment 174980: Patch
https://bugs.webkit.org/attachment.cgi?id=174980&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174980&action=review


This is a great fix, but I think it is generally clearer to do an early return.
R- to make that small change.

Also, it would be nice if these Davison bugs could be covered by some kind of
test.

> Source/WebCore/ChangeLog:5
> +

Is there any way to test this in our current testing infrastructure

> Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:98
> +	   if (frameAtIndex(i)) {

I think this might be better as an early return.