[webkit-reviews] review granted: [Bug 102735] Ignore out-of-range numbers in CSS : [Attachment 175081] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 102735: Ignore out-of-range numbers in CSS
https://bugs.webkit.org/show_bug.cgi?id=102735

Attachment 175081: Patch
https://bugs.webkit.org/attachment.cgi?id=175081&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175081&action=review


Looms good tome, too.

Please correct my minor nit on the a/an when landing.

R=me.

> Source/WebCore/ChangeLog:26
> +	   Return an Length with the type set to Undefined for unsupported

Nit: return *a* length with ...

> Source/WebCore/css/CSSPrimitiveValue.cpp:-483
> -    return Length(static_cast<float>(value > intMaxForLayoutUnit || value <
intMinForLayoutUnit ? 0.0 : value), Fixed);

Based on the naming of these limits, it almost seems like these bounds should
be inclusive. However, they have obviously not been used this way
historically...

> Source/WebCore/css/CSSPrimitiveValue.cpp:483
> +    if (value > intMaxForLayoutUnit || value < intMinForLayoutUnit)

Whoops! They are inclusive. Never mind! :)