[webkit-reviews] review granted: [Bug 102704] [EFL] Add fallback for WebkitTestRunner if opengl is not available. : [Attachment 175024] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has granted Viatcheslav Ostapenko
<ostap73 at gmail.com>'s request for review:
Bug 102704: [EFL] Add fallback for WebkitTestRunner if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=102704

Attachment 175024: Patch
https://bugs.webkit.org/attachment.cgi?id=175024&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175024&action=review


> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:36
> +    ecoreEvas = ecore_evas_new(engine, 0, 0, 800, 600, 0);

I would add a comment here // Graceful fallback to software rendering if
evas_gl engine is not available.