[webkit-reviews] review granted: [Bug 84796] Implement the new stacking layer needed by the Fullscreen API and the new <dialog> element : [Attachment 174612] sync

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Matt Falkenhagen
<falken at chromium.org>'s request for review:
Bug 84796: Implement the new stacking layer needed by the Fullscreen API and
the new <dialog> element
https://bugs.webkit.org/show_bug.cgi?id=84796

Attachment 174612: sync
https://bugs.webkit.org/attachment.cgi?id=174612&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174612&action=review


As mentioned on IRC, there is no logic for detaching / reattaching the top
layer elements' when we insert or remove them. When the spec says we should
change the top layer bit of an element, it already has to be detached (e.g.
showModalDialog) so it should be fine but better to keep that in mind.

> LayoutTests/fast/dom/HTMLDialogElement/top-layer-display-none.html:49
> +document.getElementById('container').style.display = 'none';
> +document.getElementById('displayNoneChild2').showModal();

Not sure this line helps as 'displayNoneChild2' already matches .hidden.

It is probably better to not have 'displayNoneChild2' with .hidden but then add
hidden to container's classList.