[webkit-reviews] review denied: [Bug 97192] [GTK] no volume slider in HTML5 media element controls : [Attachment 175000] Partially reverting r115829, new baseline and updated test expectations

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 97192: [GTK] no volume slider in HTML5 media element controls
https://bugs.webkit.org/show_bug.cgi?id=97192

Attachment 175000: Partially reverting r115829, new baseline and updated test
expectations
https://bugs.webkit.org/attachment.cgi?id=175000&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175000&action=review


Looks good, just a nit to fix :) We need to sync with Gustavo when landing this
patch though, so no cq for this time.

> LayoutTests/platform/gtk-wk2/TestExpectations:589
> +Bug(GTK) media/track/track-cue-container-rendering-position.html [ Failure ]


It'd be nice to open a bug ASAP and mention it in the test expectation. So it's
not forgotten after.

> LayoutTests/platform/gtk/TestExpectations:1394
> +Bug(GTK) media/media-document-audio-repaint.html [ Failure ]
> +Bug(GTK) media/track/track-cue-container-rendering-position.html [ Failure ]

> +Bug(GTK) media/track/track-cue-rendering-horizontal.html [ Failure ]
> +Bug(GTK) media/track/track-cue-rendering-vertical.html [ Failure ]

Ditto!