[webkit-reviews] review granted: [Bug 102531] [EFL][WK2] Web Inspector crashes if evas_gl is not available : [Attachment 174713] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 12:36:44 PST 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Yael
<yael at webkit.org>'s request for review:
Bug 102531: [EFL][WK2] Web Inspector crashes if evas_gl is not available
https://bugs.webkit.org/show_bug.cgi?id=102531

Attachment 174713: Patch
https://bugs.webkit.org/attachment.cgi?id=174713&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174713&action=review


> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:93
> +    if (!m_inspectorWindow)

I would add comment here // Gracefully fall back to software if evas_gl engine
is not available.


More information about the webkit-reviews mailing list