[webkit-reviews] review granted: [Bug 102693] webkitpy unit tests should run serially when checking code coverage : [Attachment 174993] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 11:55:15 PST 2012


Dirk Pranke <dpranke at chromium.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 102693: webkitpy unit tests should run serially when checking code coverage
https://bugs.webkit.org/show_bug.cgi?id=102693

Attachment 174993: Patch
https://bugs.webkit.org/attachment.cgi?id=174993&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174993&action=review


Thanks for looking at this! I had noticed this but hadn't gotten around to
posting a patch.

> Tools/Scripts/webkitpy/test/main.py:138
> +	       self.printer.write("Checking code coverage, so running things
serially\n")

What's wrong with using _log.warning() for this and the above?


More information about the webkit-reviews mailing list