[webkit-reviews] review granted: [Bug 102592] NetworkProcess Authentication : [Attachment 174836] Patch v1 - Take care of basic authentication

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 102592: NetworkProcess Authentication
https://bugs.webkit.org/show_bug.cgi?id=102592

Attachment 174836: Patch v1 - Take care of basic authentication
https://bugs.webkit.org/attachment.cgi?id=174836&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174836&action=review


> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:317
> +    return
OSAtomicIncrement64Barrier(&uniqueCanAuthenticateAgainstProtectionSpaceID);

Why not use WTF::atomicIncrement?

> Source/WebKit2/WebProcess/Network/WebResourceLoader.h:94
>      RefPtr<WebCore::ResourceLoader> m_coreLoader;
> +    WebCore::AuthenticationChallenge m_currentAuthenticationChallenge;

What is the reason to not use a pointer? Not all requests even have
authentication.