[webkit-reviews] review granted: [Bug 100738] [Shadow DOM] Changing id, className, or attribute should invalidate distribution : [Attachment 174888] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 100738: [Shadow DOM] Changing id, className, or attribute should invalidate
distribution
https://bugs.webkit.org/show_bug.cgi?id=100738

Attachment 174888: Patch
https://bugs.webkit.org/attachment.cgi?id=174888&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174888&action=review


This patch has grown! :)

> Source/WebCore/ChangeLog:22
> +	   will be the most affected by this patch. However, it's only 2%
performance regression.

I am willing to say okay to this regression, only because it's such a silly use
case. There's no need for anyone to modify an attribute in a tight loop like
that.

> Source/WebCore/dom/Node.h:238
> +    bool isInsertionPoint() const { return getFlag(IsInsertionPointFlag); }

What if instead, we stored the state of whether the node's attributes would
affect distribution here? Just a thought.