[webkit-reviews] review granted: [Bug 102664] Coordinated Graphics: refactor syncCanvas to handle the lifecycle clearly. : [Attachment 174919] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 102664: Coordinated Graphics: refactor syncCanvas to handle the lifecycle
clearly.
https://bugs.webkit.org/show_bug.cgi?id=102664

Attachment 174919: Patch
https://bugs.webkit.org/attachment.cgi?id=174919&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174919&action=review


Please fix comments before cq?
(You don't need to r? again)

> Source/WebCore/ChangeLog:8
> +	   As refactoring Coordinated Graphics in WebKit2, code related to
TexMap

TexMap -> TextureMapper

> Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h:53
> +class GraphicsSurface : public ThreadSafeRefCounted<GraphicsSurface> {

This belongs in a different patch.

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:42
> +    if (!surface) {
> +	   m_graphicsSurface.clear();
> +	   return;
>      }

This is redundant.

>
Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages
.in:54
> +    RemoveCanvas(uint32_t id)

DestroyCanvas.
(Remove pairs with Add, Destroy pairs with Create)