[webkit-reviews] review granted: [Bug 102630] JSC should have more logging in structure-related code : [Attachment 174875] the patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 102630: JSC should have more logging in structure-related code
https://bugs.webkit.org/show_bug.cgi?id=102630

Attachment 174875: the patch
https://bugs.webkit.org/attachment.cgi?id=174875&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174875&action=review


> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2202
> +		   JSCell* origin =
m_dfgData->transitions[i].m_codeOrigin.get();
> +		   JSCell* from = m_dfgData->transitions[i].m_from.get();
> +		   JSCell* to = m_dfgData->transitions[i].m_to.get();

You could use a local reference to m_dfgData->transitions[i] to avoid getting
it thrice.