[webkit-reviews] review granted: [Bug 102039] [Chromium] Add tests for week suggestion picker : [Attachment 174642] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 102039: [Chromium] Add tests for week suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=102039

Attachment 174642: Patch
https://bugs.webkit.org/attachment.cgi?id=174642&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174642&action=review


> LayoutTests/platform/chromium/TestExpectations:2827
> +webkit.org/b/99421
platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearan
ce-rtl.html [ Pass ImageOnlyFailure ]
> +webkit.org/b/99421
platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearan
ce-with-scroll-bar.html [ Pass ImageOnlyFailure ]
> +webkit.org/b/99421
platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearan
ce.html [ Pass ImageOnlyFailure ]

They should have Missing.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-appearance-with-scroll-bar.html:13
> +<input type=week id=week value="10000-W12" list="suggestions" style="width:
100px;">

The spin button and the picker indicator are drawn outside of the input bounds.
 Is it expected?

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-key-operations.html:90
> +description("Tests that key bindings work as expected.");
> +
> +debug('Check that page popup doesn\'t exist at first.');

nit: Quotation mark usage is inconsistent.  " is used for description(), ' is
used for debug().

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-key-operations.html:160
> +    debug('Open calendar picker.');
> +    expectingDidHideEvent = true;
> +    popupWindow.addEventListener("didHide", testDidHide, false);
> +    popupWindow.addEventListener("didOpenPicker", test3, false);
> +    eventSender.keyDown('\n');

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-key-operations.html:166
> +    popupWindow.removeEventListener("didHide", testDidHide);
> +
> +    shouldBeTrue('expectingDidHideEvent');

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-key-operations.html:173
> +    popupWindow.removeEventListener("didOpenPicker", test3);
> +
> +    shouldBeFalse('expectingDidHideEvent');

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-key-operations.html:189
> +    sendKey(document.getElementById('week'), "F4");
> +    if (document.getElementById('mock-page-popup'))
> +	   testPassed("F4 opened picker.");

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-mouse-operations.html:97
> +    debug('Check that hovering over an entry highlights it.');
> +   
hoverOverElement(popupWindow.document.querySelector(".suggestion-list-entry:nth
-child(2)"));

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-mouse-operations.html:105
> +    debug('Check that mouse click closes the popup and sets the value.');
> +   
clickElement(popupWindow.document.querySelector(".suggestion-list-entry:nth-chi
ld(3)"));

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-mouse-operations.html:122
> +    var suggestionList =
popupWindow.document.getElementsByClassName("suggestion-list")[0];
> +
> +    debug('Check that you can scroll using the mouse wheel.');

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-mouse-operations.html:148
> +    debug('Check that you can scroll using the scroll bar.');
> +
> +    var suggestionList =
popupWindow.document.getElementsByClassName("suggestion-list")[0];

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-reset-value-after-reload.html:24
> +    shouldBeEqualToString('highlightedEntry()', '2012-W01');
> +    eventSender.keyDown("\n");

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-reset-value-after-reload.html:41
> +    shouldBeEqualToString('highlightedEntry()', '2012-W01');
> +    eventSender.keyDown("\n");

ditto.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/week-suggestion-pick
er-reset-value-after-reload.html:49
> +   
shouldBeEqualToString('iframe.contentDocument.getElementById("test2").value',
'2012-W01');
> +
> +    iframe.addEventListener("load", function () { parent.runOnIFrameLoad();
});

ditto.