[webkit-reviews] review granted: [Bug 95964] Apply the resolved viewport rules : [Attachment 174703] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Thiago Marcos P.
Santos <tmpsantos at gmail.com>'s request for review:
Bug 95964: Apply the resolved viewport rules
https://bugs.webkit.org/show_bug.cgi?id=95964

Attachment 174703: Patch
https://bugs.webkit.org/attachment.cgi?id=174703&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174703&action=review


> Source/WebCore/css/ViewportStyleResolver.cpp:58
> +    if (deviceScaleFactor != 1)
> +	   m_initialViewportSize.scale(1.f / deviceScaleFactor);

Why does these have to be divided? The viewport should already be in css units.
Since you are not testing this anyway, I would remove it from this patch.