[webkit-reviews] review granted: [Bug 102606] Simulated mouse events should return an accurate offset. : [Attachment 174843] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 102606: Simulated mouse events should return an accurate offset.
https://bugs.webkit.org/show_bug.cgi?id=102606

Attachment 174843: Patch
https://bugs.webkit.org/attachment.cgi?id=174843&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174843&action=review


> Source/WebCore/ChangeLog:10
> +	   Remove an old check to avoid adjusting the offset location, because
we now recalculate the
> +	   offset from scratch and cache it.

It took me awhile to realize what you meant here.  I thought you were implying
that this change also made us cache the offset.

Maybe clarify something like:
"Originally we did the isSimulated check.  Then sometime later, we started
caching the offset.  I realized that caching the offset made the isSimulated
check irrelevant, so lets remove it"