[webkit-reviews] review granted: [Bug 102520] [WK2] After web process crash a new web process is created for every existing page : [Attachment 174816] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 17 21:07:54 PST 2012


Alexey Proskuryakov <ap at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 102520: [WK2] After web process crash a new web process is created for
every existing page
https://bugs.webkit.org/show_bug.cgi?id=102520

Attachment 174816: Updated patch
https://bugs.webkit.org/attachment.cgi?id=174816&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174816&action=review


> Source/WebKit2/UIProcess/WebContext.h:221
> +    PassRefPtr<WebProcessProxy> getOrCreateSharedWebProcess();

I think that this should still be called ensureSharedWebProcess, and return a
plain pointer. There is no passing of ownership, so PassRefPtr is confusing.


More information about the webkit-reviews mailing list