[webkit-reviews] review granted: [Bug 101801] [Texmap][CSS Shaders] Reuse the precompiled shader for custom filters in TextureMapperGL : [Attachment 174832] Patch V2

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 101801: [Texmap][CSS Shaders] Reuse the precompiled shader for custom
filters in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=101801

Attachment 174832: Patch V2
https://bugs.webkit.org/attachment.cgi?id=174832&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174832&action=review


Very nice!
Some pre-landing nits below...

>
Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
:270
> +	       int programId = 0;
> +	       if (!decoder->decode(programId))

programID

> Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterOperation.h:50
> +    int programId() const { return m_programId; }

programID()
and m_programID
(WebKit style)

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:313
> +	   }
> +	   WebCustomFilterOperation* customOperation =
static_cast<WebCustomFilterOperation*>(operation);

Add line break

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:319
> +	   if (iter == m_customFilterPrograms.end()) {
> +	       ASSERT_NOT_REACHED();
> +	       continue;
> +	   }

ASSERT(iter != m_customFilterPrograms.end())

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:338
> +    if (iter == m_customFilterPrograms.end()) {
> +	   ASSERT_NOT_REACHED();
> +	   return;
> +    }

Ditto