[webkit-reviews] review granted: [Bug 102555] Store MutationObserver callback in a hidden property for V8 : [Attachment 174799] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 102555: Store MutationObserver callback in a hidden property for V8
https://bugs.webkit.org/show_bug.cgi?id=102555

Attachment 174799: Patch
https://bugs.webkit.org/attachment.cgi?id=174799&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174799&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3287
> -    static PassRefPtr<${className}> create(v8::Local<v8::Value> value,
ScriptExecutionContext* context)
> +    static PassRefPtr<${className}> create(v8::Local<v8::Value> value,
ScriptExecutionContext* context, v8::Local<v8::Object> owner = (v8::Object*)0)

Is there some reason to require a Local handle here?  Also, the way to make a
default parameter is as follows:

v8::Handle<v8::Object> owner = v8::Handle<v8::Object>()

In principle, we don't know that 0 maps to empty (and we don't use C-style
casts in WebKit).

> Source/WebCore/bindings/v8/V8HiddenPropertyName.h:52
> +    V(callback)

Please put this in alphabetical order.