[webkit-reviews] review granted: [Bug 102582] [Soup] CredentialStorage should only be used for HTTP-family requests : [Attachment 174808] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 102582: [Soup] CredentialStorage should only be used for HTTP-family
requests
https://bugs.webkit.org/show_bug.cgi?id=102582

Attachment 174808: Patch
https://bugs.webkit.org/attachment.cgi?id=174808&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174808&action=review


> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:873
> +    if (!d->m_user.isEmpty() || !d->m_pass.isEmpty()) {
> +	   // If credentials were specified for this request, add them to the
url,
> +	   // so that they will be passed to NetworkRequest.
> +	   KURL urlWithCredentials(firstRequest().url());
> +	   urlWithCredentials.setUser(d->m_user);
> +	   urlWithCredentials.setPass(d->m_pass);
> +	   d->m_firstRequest.setURL(urlWithCredentials);
> +    }

This is a left over, as we discussed on IRC, otherwise looks good!