[webkit-reviews] review granted: [Bug 102327] Given a PutById or GetById with a proven structure, the DFG should be able to emit a PutByOffset or GetByOffset instead : [Attachment 174789] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 102327: Given a PutById or GetById with a proven structure, the DFG should
be able to emit a PutByOffset or GetByOffset instead
https://bugs.webkit.org/show_bug.cgi?id=102327

Attachment 174789: the patch
https://bugs.webkit.org/attachment.cgi?id=174789&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174789&action=review


r=me with build fixes.

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:169
> +		   // Now before we do anything else, push the CFA forward over
the PutById

Should this be "...over the GetById" instead?