[webkit-reviews] review granted: [Bug 102555] Store MutationObserver callback in a hidden property for V8 : [Attachment 174752] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 102555: Store MutationObserver callback in a hidden property for V8
https://bugs.webkit.org/show_bug.cgi?id=102555

Attachment 174752: Patch
https://bugs.webkit.org/attachment.cgi?id=174752&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174752&action=review


This looks great.  My only question is whether V8WeakCallback is really a
property of the MutationCallback or whether it is functionality that all
callbacks should have that V8MutationObserver activates in
V8MutationObserver::constructorCallback.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3325
> +	   ${className}* wrapper = static_cast<${className}*>(parameter);

I'm not sure wrapper is the right term here.  Perhaps |object| ?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3386
> +	   m_callback.Dispose();

Should m_callback be a ScopedPersistent?  You seem to be re-implementing the
ScopedPersistent pattern.  We can fix that in a followup patch.