[webkit-reviews] review denied: [Bug 102541] Add WebInputEventAck.h to expose EventDisposition in WebCompositorInputHandlerImpl : [Attachment 174724] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 16 12:50:15 PST 2012


James Robinson <jamesr at chromium.org> has denied yusufo at chromium.org's request
for review:
Bug 102541: Add WebInputEventAck.h to expose EventDisposition in
WebCompositorInputHandlerImpl
https://bugs.webkit.org/show_bug.cgi?id=102541

Attachment 174724: Patch
https://bugs.webkit.org/attachment.cgi?id=174724&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174724&action=review


> Source/WebKit/chromium/public/WebInputEventAck.h:36
> +enum EventDisposition { DidHandle, DidNotHandle, DropEvent };

We don't need this.  Look at WebCompositorInputHandlerClient - it has
didHandleInputEvent() and didNotHandleInputEvent(bool) already


More information about the webkit-reviews mailing list