[webkit-reviews] review denied: [Bug 102422] Add setChecked API in WebInputElement : [Attachment 174742] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Raman Kumar <ramankk at chromium.org>'s
request for review:
Bug 102422: Add setChecked API in WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=102422

Attachment 174742: Patch
https://bugs.webkit.org/attachment.cgi?id=174742&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174742&action=review


> Source/WebKit/chromium/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

Please fill out this part of the ChangeLog.

> Source/WebKit/chromium/public/WebInputElement.h:77
> +	   WEBKIT_EXPORT void setChecked(bool, bool sendChangeEvent = false);

Can we use an enum for the second parameter rather than a raw boolean?	It
looks like HTMLInputElement already uses an enum.