[webkit-reviews] review granted: [Bug 102110] REGRESSION(r129644): User StyleSheet not applying : [Attachment 174731] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 16 12:00:23 PST 2012


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 102110: REGRESSION(r129644): User StyleSheet not applying
https://bugs.webkit.org/show_bug.cgi?id=102110

Attachment 174731: patch
https://bugs.webkit.org/attachment.cgi?id=174731&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174731&action=review


r=me..

> Source/WebCore/css/StyleResolver.cpp:346
> +    for (unsigned i = 0; i < userSheets.size(); i++) {

++i

> Source/WebCore/css/StyleResolver.cpp:2583
> +    for (size_t i = 0; i < sheets.size(); ++i)

size_t!

> Source/WebCore/dom/DocumentStyleSheetCollection.cpp:82
> +    for (size_t i = 0; i < m_userStyleSheets.size(); ++i)

size_t again!


More information about the webkit-reviews mailing list