[webkit-reviews] review granted: [Bug 102507] StyleResolver: Optimize sharing candidate evaluation for elements with shared attribute data. : [Attachment 174680] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 102507: StyleResolver: Optimize sharing candidate evaluation for elements
with shared attribute data.
https://bugs.webkit.org/show_bug.cgi?id=102507

Attachment 174680: Patch
https://bugs.webkit.org/attachment.cgi?id=174680&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=174680&action=review


> Source/WebCore/css/StyleResolver.cpp:1205
> +    // Optimization: Avoid pointless comparisons when the elements share the
same attribute data.
> +    if (element->attributeData() != m_element->attributeData()) {
> +	   if (element->fastGetAttribute(XMLNames::langAttr) !=
m_element->fastGetAttribute(XMLNames::langAttr))

Might be nice to factor the attribute specific tests to a function.