[webkit-reviews] review granted: [Bug 102470] Web Inspector: don't show an Error when evaluating a watch expression results in an exception : [Attachment 174623] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 16 01:59:55 PST 2012
Vsevolod Vlasov <vsevik at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 102470: Web Inspector: don't show an Error when evaluating a watch
expression results in an exception
https://bugs.webkit.org/show_bug.cgi?id=102470
Attachment 174623: Patch
https://bugs.webkit.org/attachment.cgi?id=174623&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174623&action=review
> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:394
> + } else {
remove brackets
> Source/WebCore/inspector/front-end/inspector.css:-1651
> -.watch-expressions-error-level {
I'd keep it red.
More information about the webkit-reviews
mailing list