[webkit-reviews] review granted: [Bug 102339] Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer. : [Attachment 174541] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted lazyboy at chromium.org's request for
review:
Bug 102339: Provide page/window coordinates to plugin's local coordinates
translation in WebPluginContainer.
https://bugs.webkit.org/show_bug.cgi?id=102339

Attachment 174541: Patch
https://bugs.webkit.org/attachment.cgi?id=174541&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174541&action=review


Thanks.  One (minor) question below.

> Source/WebKit/chromium/tests/FrameTestHelpers.h:46
> +class TestWebFrameClient : public WebFrameClient {
> +};

What's the point of exposing the class?

> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:71
> +class TestPluginWebFrameClient : public FrameTestHelpers::TestWebFrameClient
{

It seesms like this class could just as easily inherit from WebFrameClient
directly.