[webkit-reviews] review denied: [Bug 93011] [CSS Shaders] Add IDL file and bindings for mix function : [Attachment 174507] Patch (Rebased)

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has denied Michelangelo De Simone
<michelangelo at webkit.org>'s request for review:
Bug 93011: [CSS Shaders] Add IDL file and bindings for mix function
https://bugs.webkit.org/show_bug.cgi?id=93011

Attachment 174507: Patch (Rebased)
https://bugs.webkit.org/attachment.cgi?id=174507&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174507&action=review


>> Source/WebCore/css/WebKitCSSMixFunctionValue.idl:32
>> +] interface WebKitCSSMixFunctionValue : CSSValueList {
> 
> I think you also need to add the "WebKitCSSMixFunctionValueConstructor" to
the DOMWindow.idl . Also, I think there's a test you need to update after that.

> 
> attribute CSSValueConstructor CSSValue;
> attribute CSSPrimitiveValueConstructor CSSPrimitiveValue;
> attribute CSSValueListConstructor CSSValueList;
> attribute WebKitCSSTransformValueConstructor WebKitCSSTransformValue;

Alex is right. You'll need to update two tests. One is window, the other is an
SVG version of the same.