[webkit-reviews] review granted: [Bug 102426] Ignore autocomplete=off for chrome generated passwords. : [Attachment 174521] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 15 14:45:19 PST 2012
Adam Barth <abarth at webkit.org> has granted Yue Zhang <zysxqn at chromium.org>'s
request for review:
Bug 102426: Ignore autocomplete=off for chrome generated passwords.
https://bugs.webkit.org/show_bug.cgi?id=102426
Attachment 174521: Patch
https://bugs.webkit.org/attachment.cgi?id=174521&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174521&action=review
>> Source/WebKit/chromium/public/WebPasswordFormData.h:111
>> + : passwordShouldAutocomplete(false)
>
> Weird number of spaces at line-start. Are you using a 4-space indent?
[whitespace/indent] [3]
Yeah, you need two more spaces.
More information about the webkit-reviews
mailing list