[webkit-reviews] review granted: [Bug 102426] Ignore autocomplete=off for chrome generated passwords. : [Attachment 174518] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 15 14:37:40 PST 2012
Adam Barth <abarth at webkit.org> has granted Yue Zhang <zysxqn at chromium.org>'s
request for review:
Bug 102426: Ignore autocomplete=off for chrome generated passwords.
https://bugs.webkit.org/show_bug.cgi?id=102426
Attachment 174518: Patch
https://bugs.webkit.org/attachment.cgi?id=174518&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174518&action=review
> Source/WebKit/chromium/public/WebPasswordFormData.h:110
> + WebPasswordFormData(): passwordShouldAutocomplete(false) { }
This isn't in quite the right style. The appropriate style is as follows:
WebPasswordFormData()
: passwordShouldAutocomplete(false)
{
}
More information about the webkit-reviews
mailing list