[webkit-reviews] review granted: [Bug 102424] [chromium] Add unit tests for ChromeClientImpl::getNavigationPolicy : [Attachment 174516] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 102424: [chromium] Add unit tests for ChromeClientImpl::getNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=102424

Attachment 174516: Patch
https://bugs.webkit.org/attachment.cgi?id=174516&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174516&action=review


> Source/WebKit/chromium/tests/ChromeClientImplTest.cpp:49
> +void setCurrentInputEventForTest(const WebInputEvent* event)
> +{
> +    WebViewImpl::m_currentInputEvent = event;
> +}

Would you be willing to put this in WebViewImpl.cpp?  The friend trick is nice,
but having some distant file poke at private member variables seems worse that
linking an extra one-line function into the production build.