[webkit-reviews] review denied: [Bug 102414] [Texmap][CSS Shaders] Make the CustomFilterValidatedProgram maintain the platform compiled program : [Attachment 174503] Patch V2

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 102414: [Texmap][CSS Shaders] Make the CustomFilterValidatedProgram
maintain the platform compiled program
https://bugs.webkit.org/show_bug.cgi?id=102414

Attachment 174503: Patch V2
https://bugs.webkit.org/attachment.cgi?id=174503&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174503&action=review


> Source/WebCore/WebCore.gyp/WebCore.gyp:118
>	 '../platform/graphics/filters',
> +	 '../platform/graphics/filters/texmap',
>	 '../platform/graphics/filters/skia',

Google doesn't use texture mapper, why is this needed, seems wrong

> Source/WebCore/WebCore.gypi:4955
>	       'platform/graphics/efl/IntRectEfl.cpp',
> +	      
'platform/graphics/filters/texmap/CustomFilterValidatedProgramTextureMapper.cpp
',
> +	      
'platform/graphics/filters/texmap/TextureMapperPlatformCompiledProgram.h',
>	       'platform/graphics/filters/CustomFilterArrayParameter.h',
>	       'platform/graphics/filters/CustomFilterConstants.h',

Same here