[webkit-reviews] review granted: [Bug 102283] IndexedDB: Indexing tests are flaky-crashing : [Attachment 174498] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 13:06:34 PST 2012


Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 102283: IndexedDB: Indexing tests are flaky-crashing
https://bugs.webkit.org/show_bug.cgi?id=102283

Attachment 174498: Patch
https://bugs.webkit.org/attachment.cgi?id=174498&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174498&action=review


> Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp:251
> +    RefPtr<IDBTransactionBackendImpl> self(this);

Nit: It's common in WebKit code to name this type of self reference protect or
protector (you can grep for other examples of this).


More information about the webkit-reviews mailing list