[webkit-reviews] review denied: [Bug 98660] RenderBoxModelObject::paintTranslucentBorderSides() creates needless transparency layers : [Attachment 174464] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tom Hudson
<tomhudson at google.com>'s request for review:
Bug 98660: RenderBoxModelObject::paintTranslucentBorderSides() creates needless
transparency layers
https://bugs.webkit.org/show_bug.cgi?id=98660

Attachment 174464: Patch
https://bugs.webkit.org/attachment.cgi?id=174464&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174464&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:1963
> +    BorderEdgeFlags edgesToDraw = 0;
> +    for (int i = BSTop; i <= BSLeft; ++i)
> +	   if (edges[i].shouldRender())
> +	       edgesToDraw |= edgeFlagForSide(static_cast<BoxSide>(i));

I don't like changing the value of input parameters. Why is this necessary
here?