[webkit-reviews] review denied: [Bug 102229] Add the --order option to NRWT : [Attachment 174481] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 11:06:37 PST 2012


Csaba Osztrogonac <ossy at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 102229: Add the --order option to NRWT
https://bugs.webkit.org/show_bug.cgi?id=102229

Attachment 174481: Patch
https://bugs.webkit.org/attachment.cgi?id=174481&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
r- now, because it isn't applyable, and the half applied patch killed the Qt
EWS :-/

Failed to run "['/storage/WebKit-qt-ews/Tools/Scripts/webkit-patch',
'--status-host=queues.webkit.org', '--bot-i..." exit_code: 1

Traceback (most recent call last):
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkit-patch", line 44, in
<module>
    from webkitpy.tool.main import WebKitPatch
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/tool/main.py", line 37,
in <module>
    from webkitpy.common.host import Host
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/common/host.py", line 38,
in <module>
    from webkitpy.common.net.buildbot.chromiumbuildbot import ChromiumBuildBot
  File
"/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuil
dbot.py", line 32, in <module>
    from webkitpy.layout_tests.port.builders import builder_path_from_name
  File
"/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/layout_tests/port/__init__.py",
line 34, in <module>
    from base import Port  # It's possible we don't need to export this virtual
baseclass outside the module.
  File
"/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/layout_tests/port/base.py", line
51, in <module>
    from webkitpy.common import find_files
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/common/find_files.py",
line 47, in <module>
    from webkitpy.common import natural_order
ImportError: cannot import name natural_order


More information about the webkit-reviews mailing list