[webkit-reviews] review denied: [Bug 102339] Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer. : [Attachment 174357] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied lazyboy at chromium.org's request for
review:
Bug 102339: Provide page/window coordinates to plugin's local coordinates
translation in WebPluginContainer.
https://bugs.webkit.org/show_bug.cgi?id=102339

Attachment 174357: Patch
https://bugs.webkit.org/attachment.cgi?id=174357&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174357&action=review


> Source/WebKit/chromium/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

Please fill out this part of the ChangeLog.

> Source/WebKit/chromium/tests/FrameTestHelpers.cpp:60
> +    virtual WebPlugin* createPlugin(WebFrame* frame, const WebPluginParams&
params) OVERRIDE

We shouldn't need to add this to every TestWebFrameClient.  The tests in
WebPluginContainerTest.cpp should create a new subclass of TestWebFrameClient
that adds this override.

> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:66
> +WebPluginContainerImpl* getWebPluginContainer(WebView* webView, const
WebString& id)

This function dives too much into WebCore.  We should be able to write these
tests in terms of the WebKit API, not in terms of WebCore implementation
details.