[webkit-reviews] review granted: [Bug 102328] MutationObserver wrapper should not be collected while still observing : [Attachment 174350] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 10:21:57 PST 2012


Adam Barth <abarth at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 102328: MutationObserver wrapper should not be collected while still
observing
https://bugs.webkit.org/show_bug.cgi?id=102328

Attachment 174350: Patch
https://bugs.webkit.org/attachment.cgi?id=174350&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174350&action=review


> Source/WebCore/dom/MutationObserver.cpp:60
> -PassRefPtr<MutationObserver>
MutationObserver::create(PassRefPtr<MutationCallback> callback)
> +PassRefPtr<MutationObserver>
MutationObserver::create(PassRefPtr<MutationCallback> callback,
ScriptExecutionContext* context)

Don't we usually pass the ScriptExecutionContext as the first argument?


More information about the webkit-reviews mailing list