[webkit-reviews] review denied: [Bug 102394] [Soup] Null-checking is required in cookiesEnabled : [Attachment 174455] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 102394: [Soup] Null-checking is required in cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=102394

Attachment 174455: Patch
https://bugs.webkit.org/attachment.cgi?id=174455&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> The context could be null, when document or frame or loader is null

This can never happen in Navigator::cookieEnabled() - it checks that m_frame is
not null, and others can never be null.

> and also FrameLoaderClient can't provide a proper networking context.

This looks like the root cause for your port. The client should provide a
networking context, it makes no sense for a FrameLoader to not have one.