[webkit-reviews] review granted: [Bug 101748] [WK2][GTK][EFL] Share WebKit2-GTK's Accessibility implementation with other WebKit ports. : [Attachment 174168] [WK2][GTK][EFL] Share WebKit2-GTK's Accessibility implementation with other WebKit ports.

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 101748: [WK2][GTK][EFL] Share WebKit2-GTK's Accessibility implementation
with other WebKit ports.
https://bugs.webkit.org/show_bug.cgi?id=101748

Attachment 174168: [WK2][GTK][EFL] Share WebKit2-GTK's Accessibility
implementation with other WebKit ports.
https://bugs.webkit.org/attachment.cgi?id=174168&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174168&action=review


> Source/WebKit2/GNUmakefile.list.am:1148
> +    Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.h \
> +    Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp
\

It seems to maintain the alphabetical ordering, these should go above
Source/WebKit2/WebProcess/WebPage/gtk/WebInspectorGtk.cpp.

> Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:33
> +#include "WebPageAccessibilityObjectAtk.h"

It makes sense to keep the header name as WebPageAccessibilityObject.h since
that's the name of GObject.